For JMX I intended to address SLING-5443 which so far I have not been able to work upon. Also for SLING-5965 we would need to add Gauge support SLING-5966
I would try to get some time to work on that but cannot commit on that due to other work Chetan Mehrotra On Mon, Aug 22, 2016 at 9:29 PM, Stefan Egli <[email protected]> wrote: > Hi, > > For SLING-5965 I'd need SLING-5424 - ie commons.metrics 1.0.2 released. > That currently still has 3 open issues. Anything preventing those from > being moved to 1.0.4 and releasing 1.0.2 now? > > Cheers, > Stefan > > On 18/08/16 11:39, "Stefan Egli" <[email protected]> wrote: > >>Hi, >> >>On 16/08/16 13:51, "Stefan Egli" <[email protected]> wrote: >> >>>>2) Does the metrics library by default make all values available via >>>>JMX as well? >>> >>>That I don't know, couldn't find it at least. >> >>FYI: due to SLING-5424 (jmxReporter not started) this indeed doesn't work >>in commons.metrics-1.0.0 yet, only in 1.0.2 (not yet released). Albeit >>with an empty (JMX) 'Type' - which seems to be due to [1] not using a >>custom ObjectNameFactory as [0] does. So perhaps we should also use such a >>factory for commons metrics? >> >>Cheers, >>Stefan >>-- >>[0] >>https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java >>/ >>org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java#L77 >>[1] >>https://github.com/apache/sling/blob/trunk/bundles/commons/metrics/src/mai >>n >>/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java#L2 >>1 >>5 >> >> > >
