Hi Robert,
I updated SLING-5768 and SLING-5890 (markdown docu) for using
sling:resourceTypesWithDescendants. If everyone is reasonably happy with
it, I think we should just go with that :)
Regards
Georg
On 2016-08-01 13:56, Georg Henzler wrote:
Hi Julian,
good point that "descendants" is actually clearer than "children"...
that gives two options IMHO:
- sling:resourceTypesDeep <-- less descriptive but also shorter
- sling:resourceTypesWithDescendants <-- I think clearer, but longer
For the simple match, I would stick with the short name
sling:resourceTypes
as it is more in line with the standard oak restrictions.
Regards
Georg
On 2016-08-01 13:48, Julian Sedding wrote:
Hi Georg
I think "...WithChildren" is misleading, because, per my understanding
of the documentation, it means "with descendants".
Maybe restriction names with "shallow" and/or "deep" would be more
self-documenting?
E.g. "sling:resourceTypesShallow" and "sling:resourceTypesDeep".
WDYT?
Regards
Julian
On Mon, Aug 1, 2016 at 1:32 PM, Georg Henzler <[email protected]>
wrote:
Hi Robert,
... I would rather see it named
org.apache.sling.jcr.oak-restrictions
and placed under contrib/jcr .
That sounds like a better location, +1 to move
There was some discussion related to the name of the
'sling:resourceTypesWithChildren' restriction [1]. I want to make
sure
that we have agreement that this is the best name
I think sling:resourceTypesWithChildren is the clearest suggestion up
to now
([1] gives an example). From a pure user point of view, the terms
"parent"
or "ancestry" would be rather misleading, because what is matched by
the
restriction in the end are nodes below (and not above) the matched
node with
the given resource type, e.g. the restriction matches a node with
resource
type "myproj/news" with (or including) all children.
Regards
Georg
[1]
https://sling.apache.org/documentation/bundles/sling-oak-restrictions.html#restriction-slingresourcetypeswithchildren
