[
https://issues.apache.org/jira/browse/SLING-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467012#comment-15467012
]
ASF GitHub Bot commented on SLING-6039:
---------------------------------------
GitHub user stefanseifert opened a pull request:
https://github.com/apache/sling/pull/166
SLING-6039 ResourceBuilder: Split up ResourceBuilder and
ResourceBuilderFactory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stefanseifert/sling
feature/SLING-6039-resourcebuilder-factory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit 79cce1881d2dd14731711ad187125ca47b368878
Author: sseifert <[email protected]>
Date: 2016-09-06T09:56:09Z
SLING-6039 ResourceBuilder: Split up ResourceBuilder and
ResourceBuilderFactory
----
> ResourceBuilder: Split up ResourceBuilder and ResourceBuilderFactory
> --------------------------------------------------------------------
>
> Key: SLING-6039
> URL: https://issues.apache.org/jira/browse/SLING-6039
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Reporter: Stefan Seifert
> Assignee: Stefan Seifert
> Priority: Minor
> Fix For: Resource Builder 1.0.0
>
>
> i do not understand why we combine the use cases
> * resource builder creation
> * resource builder usage
> in one single ResourceBuilder interface, with two implementations each only
> supporting the one part or another, throwing exception when the other methods
> are used.
> it think it would be quite cleaner and easier to understand to create a
> separate ResourceBuilderFactory interface.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
