[ 
https://issues.apache.org/jira/browse/SLING-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513034#comment-15513034
 ] 

Konrad Windszus edited comment on SLING-5999 at 9/22/16 11:42 AM:
------------------------------------------------------------------

There was never any path restriction implemented (except through bugs) or 
documented at 
http://sling.apache.org/documentation/bundles/internationalization-support-i18n.html.
 If we want to start that now that will cause a lot of pain during upgrade for 
existing software. Therefore we must be very careful when we introduce that now.
Instead this bundle always relied on nodetypes and mixins to find all 
dictionaries (both are not really a concept of Sling but rather of JCR and 
therefore not really supported by Sling API either, which lead to problems like 
the one outlined in 
https://issues.apache.org/jira/browse/SLING-4814?focusedCommentId=14591461&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14591461).
 Therefore it would probably be a good idea to rethink that approach and come 
up with an alternative way of how dictionaries stored in resources are found 
which is really independent of JCR (probably that should then also be reflected 
in the class names).


was (Author: kwin):
There was never any path restriction implemented (except through bugs) or 
documented at 
http://sling.apache.org/documentation/bundles/internationalization-support-i18n.html.
 If we want to start that now that will cause a lot of pain during upgrade for 
existing software.
Instead this bundle always relied on nodetypes and mixins to find all 
dictionaries (both are not really a concept of Sling but rather of JCR and 
therefore not really supported by Sling API either, which lead to problems like 
the one outlined in 
https://issues.apache.org/jira/browse/SLING-4814?focusedCommentId=14591461&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14591461).
 Therefore it would probably be a good idea to rethink that approach and come 
up with an alternative way of how dictionaries stored in resources are found.

> JcrResourceBundleProvider should move to new ResourceChangeListener API       
> ------------------------------------------------------------------------
>
>                 Key: SLING-5999
>                 URL: https://issues.apache.org/jira/browse/SLING-5999
>             Project: Sling
>          Issue Type: Task
>          Components: i18n
>            Reporter: Hanish Bansal
>            Assignee: Carsten Ziegeler
>             Fix For: i18n 2.5.4
>
>
> org.apache.sling.i18n.impl.JcrResourceBundleProvider currently implements 
> org.osgi.service.event.EventHandler Interface. We should start using the new 
> ResourceChangeListener API.
> See [0] for details :
> https://issues.apache.org/jira/browse/SLING-5994



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to