On Fri, 2016-10-07 at 14:03 +0200, Konrad Windszus wrote: > Hi Robert, > To be honest, I still don't quite get that. > The project configurators part should be part of m2e-ui (https://gith > ub.com/apache/sling/tree/trunk/tooling/ide/eclipse-m2e- > ui/src/org/apache/sling/ide/eclipse/m2e/internal). > The (incremental) manifest generation is now being done through the > maven-bundle-plugin since 3.2.0 natively (https://issues.apache.org/j > ira/browse/FELIX-4009). The same for the maven-scr-plugin > (https://issues.apache.org/jira/browse/FELIX-3358). > So which code part of m2e-tycho is really necessary here?
m2e-tycho is IIRC only necessary for old versions of the maven plugins that need a m2e configurator. Robert > > When looking through the code at https://github.com/tesla/m2eclipse-t > ycho/ it seems that really only https://github.com/tesla/m2eclipse- > tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/f > elix/internal/MavenBundlePluginConfigurator.java might be relevant > and there our own project configurator should be enough (https://gith > ub.com/apache/sling/blob/trunk/tooling/ide/eclipse-m2e- > ui/src/org/apache/sling/ide/eclipse/m2e/internal/BundleProjectConfigu > rator.java). > > If really both configurators are necessary to get things running we > should try to figure out which part of https://github.com/tesla/m2ec > lipse- > tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/f > elix/internal/MavenBundlePluginConfigurator.java needs to be taken > over to https://github.com/apache/sling/blob/trunk/tooling/ide/eclips > e-m2e- > ui/src/org/apache/sling/ide/eclipse/m2e/internal/BundleProjectConfigu > rator.java to make things work. > > Do you by chance remember what exactly was not working when you > didn't have the m2e-tycho plugin installed? > Thanks, > Konrad > > > On 7 Oct 2016, at 13:43, Robert Munteanu <[email protected]> > > wrote: > > > > Hi Konrad, > > > > On Fri, 2016-10-07 at 12:20 +0200, Konrad Windszus wrote: > > > Currently the m2e-feature of the Sling IDE still requires the > > > feature > > > org.sonatype.tycho.m2e.feature (https://github.com/apache/sling/b > > > lob/ > > > 4df9ab2d6592422889c71fa13afd453a10a5a626/tooling/ide/m2e- > > > feature/feature.xml#L229 > > > <https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13af > > > d453 > > > a10a5a626/tooling/ide/m2e-feature/feature.xml#L229>) > > > Since the latter seems rather unmaintained I would like to get > > > rid of > > > that dependency which was added in the context of https://issues. > > > apac > > > he.org/jira/browse/SLING-3608 > > > <https://issues.apache.org/jira/browse/SLING-3608>. > > > > > > This is also important since newer versions of the maven-bundle- > > > plugin conflict with that extension (https://issues.apache.org/ji > > > ra/b > > > rowse/FELIX- > > > 4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.sys > > > tem. > > > issuetabpanels:comment-tabpanel#comment-15192263 > > > <https://issues.apache.org/jira/browse/FELIX- > > > 4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.sys > > > tem. > > > issuetabpanels:comment-tabpanel#comment-15192263>) > > > > > > @Robert: Do you have any idea why this was initially added? > > > SLING- > > > 3608 does not give much hints here. There should be no explicit > > > runtime dependency to any tycho code IMHO. > > > > > > The dependency is there to make sure that the OSGi metadata ( > > manifest, > > SCR descriptors, etc ) is generated and put in the right location. > > > > Without the tycho-m2e feature things will be broken out of the box. > > > > So while there is no hard dependency, it is in my opinion required, > > at > > least for now. > > > > How to gracefully accommodate the transition is another issue, and > > I > > don't have a good answer for that. > > > > Robert > > >
