[
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555059#comment-15555059
]
Konrad Windszus edited comment on SLING-6112 at 10/7/16 1:29 PM:
-----------------------------------------------------------------
The plugin.xml in
https://github.com/apache/sling/blob/trunk/tooling/ide/eclipse-m2e-ui/plugin.xml#L54
still references the m2e-tycho confiigurator in the {{secondaryTo}} attribute.
This refers to
https://github.com/tesla/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/lifecycle-mapping-metadata.xml#L113.
We should change to
http://git.eclipse.org/c/m2e/m2e-core.git/tree/org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/JavaProjectConfigurator.java
(with id="org.eclipse.m2e.jdt.javaConfigurator",
http://git.eclipse.org/c/m2e/m2e-core.git/tree/org.eclipse.m2e.jdt/plugin.xml#n42).
The only question is whether we should stick to the deprecated {{secondaryTo}}
logic or rely on the new {{runsAfter}} being introduced with m2e 1.6
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=449495)?
was (Author: kwin):
There seems to be a bug in
https://github.com/apache/sling/blob/trunk/tooling/ide/eclipse-m2e-ui/plugin.xml#L54
in the {{secondaryTo}} attribute. This is supposed to refer to another
configurator id. But the configurator with id {{maven-bundle-plugin}} does just
not exist (neither in m2e nor in m2e-tycho).
What was meant is probably
http://git.eclipse.org/c/m2e/m2e-core.git/tree/org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/JavaProjectConfigurator.java
(with id="org.eclipse.m2e.jdt.javaConfigurator",
http://git.eclipse.org/c/m2e/m2e-core.git/tree/org.eclipse.m2e.jdt/plugin.xml#n42).
The only question is whether we should stick to the deprecated {{secondaryTo}}
logic or rely on the new {{runsAfter}} being introduced with m2e 1.6
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=449495)?
> Make Sling IDE independent of m2e-tycho
> ---------------------------------------
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
> Affects Versions: Sling Eclipse IDE 1.1.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin
> conflict with that extension
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at
> http://www.mail-archive.com/[email protected]/msg60112.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
