[
https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648163#comment-15648163
]
Bertrand Delacretaz commented on SLING-5135:
--------------------------------------------
You are correct about what's left to do.
I implemented the check in {{JcrProviderStateFactory.createProviderState(...)}}
as that's where the loginAdministrative call happens, so it feels natural to me
to have the check right next to it. But if you find a better way that doesn't
break the tests I have no problem with that.
Moving the {{LoginAdminWhitelist}} interface to {{o.a.s.jcr.api}} sounds like a
good idea. We try to touch the {{o.a.s.api}} as little as possible.
> Whitelist legit usages of loginAdministrative and administrative
> ResourceResolver
> ---------------------------------------------------------------------------------
>
> Key: SLING-5135
> URL: https://issues.apache.org/jira/browse/SLING-5135
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Reporter: Antonio Sanso
> Assignee: Bertrand Delacretaz
> Attachments: SLING-5135.patch, SLING-5135.patch
>
>
> {{AbstractSlingRepositoryManager}} contains a method that disable
> loginAdministrative support
> {code}
> /**
> * Returns whether to disable the
> * {@code SlingRepository.loginAdministrative} method or not.
> *
> * @return {@code true} if {@code SlingRepository.loginAdministrative} is
> * disabled.
> */
> public final boolean isDisableLoginAdministrative()
> {code}
> This is a global configuration. It would be nice to have an extension of such
> mechanism that contains a white list of (few) legit usage of
> {{loginAdministrative}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
