[ 
https://issues.apache.org/jira/browse/SLING-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685993#comment-15685993
 ] 

Konrad Windszus commented on SLING-5939:
----------------------------------------

[~cziegeler] I think the commit is not 100% correct. You define two designates:
# 
https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/extensions/feature-flags/src/main/java/org/apache/sling/featureflags/impl/ConfiguredFeature.java#L35
 defines a designate with factoryPid 
{{org.apache.sling.featureflags.impl.ConfiguredFeature}}
# 
https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/extensions/feature-flags/src/main/java/org/apache/sling/featureflags/impl/ConfiguredFeature.java#L45
 defines a designate with factoryPid {{org.apache.sling.featureflags.Feature}}
Is it deliberate to have two different designates for the same metatype class?
Which factoryPid is the one which should be used for configuration?

> Register filter using http whiteboard
> -------------------------------------
>
>                 Key: SLING-5939
>                 URL: https://issues.apache.org/jira/browse/SLING-5939
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Feature Flags 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to