[ 
https://issues.apache.org/jira/browse/SLING-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722698#comment-15722698
 ] 

Andrei Dulvac commented on SLING-6365:
--------------------------------------

Thanks a lot Robert. As you said, that doesn't actually change anything at 
runtime, but it makes sense. How about simplifying the API then if it's always 
null, null?

> JcrInstaller incorrectly uses loginService arguments
> ----------------------------------------------------
>
>                 Key: SLING-6365
>                 URL: https://issues.apache.org/jira/browse/SLING-6365
>             Project: Sling
>          Issue Type: Bug
>          Components: Installer
>    Affects Versions: JCR Installer 3.1.20
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>            Priority: Minor
>             Fix For: JCR Installer 3.1.22
>
>
> As [~andrei.dulvac] pointed out on SLING-5228, my changes use the 'subsystem 
> name' and 'workspace' parameters inconsistently. This works because the 
> arguments are always (null, null), as we no longer have workspaces with Oak.
> However, we should make sure the arguments are always used correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to