[
https://issues.apache.org/jira/browse/SLING-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738429#comment-15738429
]
ASF GitHub Bot commented on SLING-6388:
---------------------------------------
GitHub user Buuhuu opened a pull request:
https://github.com/apache/sling/pull/189
SLING-6388: Implemented MockSession.hasPendingChanges()
Note about the changes in MockSessionTest:
I had to use a local Session for each of the @Test methods. This is because
the comment
> // methods can be called without any effect
is not right anymore, but saving the session at the end of each of the
@Test methods seemed a bit wrong imho.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Buuhuu/sling feature/SLING-6388
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #189
----
commit 8f88d8c2ecce5cd4a88eb9a18acc3d76ad8f7fa1
Author: Dirk Rudolph <[email protected]>
Date: 2016-12-10T20:16:04Z
SLING-6388: implement Item.isModified reacting on implementations of
Node.setProperty and Property.setValue() calls
commit a90378c7d2c8e00ca0178861b19943dcfcc6ca51
Author: Dirk Rudolph <[email protected]>
Date: 2016-12-10T20:18:07Z
SLING-6388: implemented tracking of session changes for MockSession
----
> Support tracking changes of JCR Mock MockSession
> ------------------------------------------------
>
> Key: SLING-6388
> URL: https://issues.apache.org/jira/browse/SLING-6388
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Affects Versions: Testing JCR Mock 1.1.16
> Reporter: Dirk Rudolph
> Priority: Minor
>
> {{org.apache.sling.testing.mock.jcr.MockSession#hasPendingChanges}} always
> returns {{false}}. This causes the {{ResourceResolver}} to return {{false}}
> for {{hasChanges()}} as well, making it difficult to use the JCR Mock
> {{ResourceResolverType}} for tests of transactional implementations using
> {{ResourceResolver}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
