[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811904#comment-15811904
]
Konrad Windszus commented on SLING-6368:
----------------------------------------
bq. do you see any significant performance with this change?
I have not tested that extensively yet. But I had a closer look at
{{DocViewNode}} and {{DocViewProperty}} and both seem rather lean to me, so I
don't expect any major differences here to the previous version from a
performance point of view.
bq. I see some changes in the manifest and build.properties and it seems jar
files are now tracked without version. What's the reason for that?
This change requires a newer version of FileVault (because older version 3.0.0
did not contain the DocViewProperty) and some of the transitive dependencies of
it (e.g. Jackrabbit API, Guava). I therefore just upgraded to the latest
release of FileVault.
I stripped the version numbers from the filename just to make upgrades in the
future easier to handle (i.e. in the best case with only a change of the
version in the pom.xml). If you are not fine with stripping the version, I can
again revert that change (that way it may be more obvious what the actual
vlt-wrapper bundle contains).
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> ---------------------------------------------------------------------------------------------
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
> Affects Versions: Sling Eclipse IDE 1.1.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch,
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
 "title": "Resolved
> Segments",
 "icon":
> "coral-Icon--targeted",
 "storeMapping":
> {
 "s": "segmentation"

> },
 "template": "<p
> class=\\"contexthub-module-line1\\">Resolved Segments</p><p
> class=\\"contexthub-module-line2\\">{{s.summary}}</p>",

> "clickable": true,
 "listReference":
> "/store/segmentation/segments",
 "listType":
> "custom",
 "listItemTemplate":
> "<span>{{label}}</span>",

> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
> "icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "<p class=\\"contexthub-module-line1\\">Resolved
> Segments</p><p class=\\"contexthub-module-line2\\">{{s.summary}}</p>",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "<span>{{label}}</span>",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
> "icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "<p class=\"contexthub-module-line1\">Resolved Segments</p><p
> class=\"contexthub-module-line2\">{{s.summary}}</p>",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "<span>{{label}}</span>",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
