[
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814800#comment-15814800
]
Robert Munteanu commented on SLING-6344:
----------------------------------------
{quote}Can someone help me to clarify the licensing issue we might run into
here?
AFAIK we are not allowed to include any non-open source code in any Apache
artifacts.
What about reverse engineering functionality being provided by external closed
source tools?
In this case the functionality which generates/merges filter.xmls?{quote}
Is probably best discussed on the dev mailing list, I don't think all the devs
are following this issue. TBH my hope would be towards creating our own open
source content-package plugin, see SLING-6195
> Support filter.xmls being generated by the content-package-maven-plugin
> -----------------------------------------------------------------------
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
> Issue Type: Bug
> Components: IDE
> Affects Versions: Sling Eclipse IDE 1.1.0
> Reporter: Konrad Windszus
> Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch,
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE
> should consider only the filter.xml in the generated artifacts (package). The
> problem with that is, that content-package-maven-plugin does only generate
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}}
> while it should return {{DENY}} to not overwrite any nodes in case the filter
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the
> resourceType from {{sling:redirect}} to just being removed which breaks the
> redirect handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
