Hi Dan,

I could reproduce this issue. It appears it was a bug in Apache commons io
2.4 that prevented to cleanup a temporary folder built during the tests, in
the specific setup where the source code is located at a path containing a
symlink and with maven -f.

I have tracked that in SLING-6524.

Although this issue does not affect the business logic, I cancel the
release and will re-spin the next version with SLING-6524 included.

Regards,

Timothee

2017-02-16 19:18 GMT+01:00 Daniel Klco <[email protected]>:

> Hi Timothee,
>
> I'm downloading the tag from SVN and running a full maven build.
> Essentially:
>
> mkdir -p /tmp/sling-build/build/1636/org.apache.sling.distribution.core
> svn export --force
> http://svn.apache.org/repos/asf/sling/tags/org.apache.
> sling.distribution.core-0.2.2
>  /tmp/sling-build/build/1636/org.apache.sling.distribution.core
> mvn clean install -f
>  /tmp/sling-build/build/1636/org.apache.sling.distribution.core/pom.xml
>
> I'm using Java 8 on a Mac.
>
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
> MaxPermSize=256m; support was removed in 8.0
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T11:41:47-05:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.8.0_112, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.3", arch: "x86_64", family: "mac"
>
> I'm not sure why the two different methods would yield different results.
>
> Thanks,
> Dan
>
> On Thu, Feb 16, 2017 at 12:52 PM, Timothée Maret <[email protected]
> >
> wrote:
>
> > Hi Dan,
> >
> > Thanks for testing the release. I could not reproduce locally though. I
> > used the following steps:
> >
> > $ sh check_staged_release.sh 1636 /tmp/sling-staging
> > $ cd
> > /tmp/sling-staging/1636/org/apache/sling/org.apache.sling.
> > distribution.core/0.2.2
> > $ unzip org.apache.sling.distribution.core-0.2.2-source-release.zip
> > $ cd org.apache.sling.distribution.core-0.2.2
> > $ mvn test
> >
> > What version of Java and Maven are you using ? How are you running the
> > tests ? Does it happen consistently ?
> >
> > Generally, the tests seem to pass as well on Jenkins as part of running
> the
> > IT tests for both Java7 and Java8:
> >
> > https://builds.apache.org/job/sling-contrib-extensions-
> > distribution-core-1.7/
> > https://builds.apache.org/job/sling-contrib-extensions-
> > distribution-core-1.8/
> >
> >
> > Regards,
> >
> > Timothee
> >
> > 2017-02-16 17:24 GMT+01:00 Daniel Klco <[email protected]>:
> >
> > > @Timothee,
> > >
> > > I am seeing an integration test failure when testing the latest code,
> can
> > > you check the logs here and verify:
> > > https://gist.github.com/klcodanr/d24e71fb13f5287b10e07b5c1a6a85cc
> > >
> > > The affected test is:
> > >
> > > SimpleDistributionQueueProviderTest.testEnableQueueProcessingWithC
> > > heckpointRecovery:111
> > > » IO
> > >
> > > Thanks,
> > > Dan
> > >
> > > On Thu, Feb 16, 2017 at 9:16 AM, Timothee Maret <[email protected]>
> > wrote:
> > >
> > > > Hi,
> > > >
> > > > We solved 3 issues in this release:
> > > > https://issues.apache.org/jira/browse/SLING/component/12323405
> > > >
> > > > There are still 5 outstanding improvement issues.
> > > >
> > > > Staging repository:
> > > > https://repository.apache.org/content/repositories/
> > orgapachesling-1636/
> > > >
> > > > You can use this UNIX script to download the release and verify the
> > > > signatures:
> > > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> > > >
> > > > Usage:
> > > > sh check_staged_release.sh 1636 /tmp/sling-staging
> > > >
> > > > Please vote to approve this release:
> > > >
> > > >   [ ] +1 Approve the release
> > > >   [ ]  0 Don't care
> > > >   [ ] -1 Don't release, because ...
> > > >
> > > > This majority vote is open for at least 72 hours.
> > > >
> > > > Regards,
> > > >
> > > > Timothee
> > > >
> > >
> >
> >
> >
> > --
> > Timothée Maret
> >
>



-- 
Timothée Maret

Reply via email to