[
https://issues.apache.org/jira/browse/SLING-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890095#comment-15890095
]
Konrad Windszus edited comment on SLING-6578 at 3/1/17 12:49 PM:
-----------------------------------------------------------------
My original intention was actually to be able to address a specific component
instance (with a specific configuration). That wouldn't be possible by using a
dedicated property like [~cziegeler] proposed, because that would be the same
for multiple component instances of the same type (being created through the
Configuration Admin).
Regarding the filter expression: This sounds like a good idea, I am just not
sure in which component to hold the service references towards the
{{Validator}}s then. Right now they are (dynamically) bound to the
{{ValidationModelRetrieverImpl}}. In case you would leverage a target filter,
you would need to get a service reference for each validator referenced in each
validation model entry individually. Isn't this too much overhead?
was (Author: kwin):
My original intention was actually to be able to address a specific component
instance (with a specific configuration). That wouldn't be possible by using a
dedicated property like [~cziegeler] proposed, because that would be the same
for multiple component instances of the same type (being created through the
Configuration Admin).
Regarding the filter expression: This sounds like a good idea, I am just not
sure in which component to hold the service references towards the Validator's
then. Right now they are (dynamically) bound to the
{{ValidationModelRetrieverImpl}}. In case you would leverage a target filter,
you would need to get a service reference for each validator referenced in each
validation model entry individually. Isn't this too much overhead?
> Use "service.pid" property instead of class name to reference validators
> ------------------------------------------------------------------------
>
> Key: SLING-6578
> URL: https://issues.apache.org/jira/browse/SLING-6578
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>
> Leveraging the component's "service.pid" property value instead of its
> classname is more stable (even if implementation changes, the PID might stay
> the same) and also allows for configuration factories to refer to a specific
> validator configuration. The fallback should be the property "component.name"
> as "service.pid" is not always necessarily set. Basically the validator
> should be referable via each of those value, i.e. one of the "service.pid"s
> or the "component.name".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
