[ 
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897088#comment-15897088
 ] 

Julian Sedding commented on SLING-6609:
---------------------------------------

I agree with [~kwin] on this one. Especially since we have explicit support for 
the {{null}} default value (aka. no default value):

{code}
// assuming "properties" is a ValueMap instance and the property "nonExistant" 
does not exist, then
assert null == properties.get("nonExistant", (String)null);
// is equivalent to
assert null == properties.get("nonExistant", String.class);
{code}

Or am I missing something?

> Fix JSR305 annotations for ValueMap.get
> ---------------------------------------
>
>                 Key: SLING-6609
>                 URL: https://issues.apache.org/jira/browse/SLING-6609
>             Project: Sling
>          Issue Type: Bug
>          Components: API
>    Affects Versions: API 2.16.2
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: API 2.16.4
>
>
> Currently {{<T> T get(@Nonnull String name, T defaultValue);}} does neither 
> define a JSR 305 annotation for the return value nor for the 2nd parameter. 
> It makes sense to define them both as {{@Nonnull}}, because if you intend to 
> get {{null}} as return value you are supposed to take the other get method 
> ({{@CheckForNull <T> T get(@Nonnull String name, @Nonnull Class<T> type)}})



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to