[
https://issues.apache.org/jira/browse/SLING-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923806#comment-15923806
]
Stefan Seifert commented on SLING-6634:
---------------------------------------
yes, this is a good idea in general. but some remarks:
* it makes not sense for parsing FileVault XML - the contentloader takes a
"shortcut" here and directly uses JCR/jackrabbit APIs to import the XML file
content without having to parse it itself - which is of course the best solution
* parsing JSON logic is currently duplicated with contentparser and should be
switched - but this would need some more refactoring inside contentloader
because it currently has it's own abstraction of parsing content and writing it
to the repository which is not in line with the simple Map-based API of
contentparser. maybe we even would have to add a "stream-based" API to
contentparser to support it
* contentloader implements a third XML-based format which is not FileVault XML
but a quite verbose custom XML format. it think no one is using it nowadays,
thus i did not even support it in contentparser. but it we want to keep support
for it for backwards compatibility it could make sense to add support for it in
contentparser as well along with the refactoring necessary for the JSON format.
> Use new FS Content Parser module in ContentLoader
> -------------------------------------------------
>
> Key: SLING-6634
> URL: https://issues.apache.org/jira/browse/SLING-6634
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR ContentLoader 2.1.10
> Reporter: Konrad Windszus
>
> With the new module being added with SLING-6592 it should be easy to add
> FileVault XML support to the JCR Contentloader.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
