[ 
https://issues.apache.org/jira/browse/SLING-6653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928118#comment-15928118
 ] 

Konrad Windszus commented on SLING-6653:
----------------------------------------

Ok, but then we should at least make the parameter working directory mandatory 
for that method.

> Make slingLaunchpadOak() private
> --------------------------------
>
>                 Key: SLING-6653
>                 URL: https://issues.apache.org/jira/browse/SLING-6653
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>    Affects Versions: Testing PaxExam 0.0.2
>            Reporter: Konrad Windszus
>
> The method {{slingLaunchpadOak()}} should never be used directly instead 
> there should always be a concrete backend being set up (i.e. 
> {{slingLaunchpadOakTar(...)}} or {{slingLaunchpadOakMongo(...)}} should be 
> used). I would propose to make this method private and to always require the 
> path to the working directory as argument. Then the 
> {{LuceneIndexProviderService}} could be configured correctly i.e. as absolute 
> path in slingLaunchpadOak(...) instead of doing it twice (once incorrect with 
> a relative path in {{slingLaunchpadOak(...)}} and once correct with the 
> absolute path in either {{slingLaunchpadOakMongo(...)}} and 
> {{slingLaunchpadOakTar()}}).
> See also the related discussion at 
> http://www.mail-archive.com/dev@sling.apache.org/msg65593.html.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to