[ 
https://issues.apache.org/jira/browse/SLING-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940530#comment-15940530
 ] 

Bertrand Delacretaz edited comment on SLING-6680 at 3/24/17 3:25 PM:
---------------------------------------------------------------------

Thanks for your contribution! I have committed it under contrib/scripting/esx 
and made minor changes in http://svn.apache.org/r1788469 and 
http://svn.apache.org/r1788470

It would be good to have integration tests, the Sling Pax Exam mechanism as 
used in bundles/extensions/org.apache.sling.resource.presence can be good for 
that. For now the manual tests described in the README worked for me, both the 
minimal rendering example and the demo.html pages, provided one runs {{npm 
install}} before building the module as described in the README.

I think we should consider this module experimental for now but it's good to 
have it IMO, I especially like the ability to use existing NodeJS modules.


was (Author: bdelacretaz):
Thanks for your contribution! I have committed it under contrib/scripting/esx 
and made minor changes in http://svn.apache.org/r1788469 and 
http://svn.apache.org/r1788470

It would be good to have integration tests, the Sling Pax Exam mechanism as 
used in bundles/extensions/org.apache.sling.resource.presence can be good for 
that.

I think we should consider this module experimental for now but it's good to 
have it IMO, I especially like the ability to use existing NodeJS modules.

> contributing esx scripting engine
> ---------------------------------
>
>                 Key: SLING-6680
>                 URL: https://issues.apache.org/jira/browse/SLING-6680
>             Project: Sling
>          Issue Type: New Feature
>          Components: Scripting
>            Reporter: Senol Tas
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: Apache Sling Scripting ESX 0.2.0
>
>         Attachments: esx.zip
>
>
> I'd like to contribute a small scripting engine which is using a nodejs like 
> module loading. 
> This module implements a Nashorn Apache Sling Script Engine for the "esx" 
> extension.
> It requires a function named render in the esx script that processes the 
> request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to