Good - lets get this release out and address it in the next one (I created SLING-6876 to track this so we don't forget to include it).
regards, Karl On Wed, May 24, 2017 at 12:01 AM, Stefan Seifert <[email protected]> wrote: > i peronally would rather include this fix as well, becaue without it > tick-escaped json creates strange results when the quoted string itself > contains ticks or quotes. either a "full" support for ticks or none at all. > > but i'm also fine with keeping this release and adding the fix to the next > one if no other objects. > > +1 on the formal release of 2.2.2 > > stefan > >>-----Original Message----- >>From: Karl Pauls [mailto:[email protected]] >>Sent: Tuesday, May 23, 2017 11:50 PM >>To: [email protected] >>Subject: Re: [VOTE] Apache Sling JCR Contentloader 2.2.2 >> >>Hi Stefan, >> >>yeah, as I just replied to your comment as well, that is certainly a >>nice improvement to support even more none standard json but I think >>we can address this in a later release (either we wait until >>SLING-6634 is done or we do an in between release where we inline your >>JsonTicksConverter). From my POV this is a best effort kinda thing and >>preferably people should use valid json to begin with. >> >>regards, >> >>Karl >> >>On Tue, May 23, 2017 at 11:10 PM, Stefan Seifert <[email protected]> >>wrote: >>> i think the logic for supporting tick-quoted json is incomplete, see >>> https://issues.apache.org/jira/browse/SLING- >>6871?focusedCommentId=16021869#comment-16021869 >>> >>> stefan >>> >>>>-----Original Message----- >>>>From: Karl Pauls [mailto:[email protected]] >>>>Sent: Tuesday, May 23, 2017 5:42 PM >>>>To: [email protected] >>>>Subject: [VOTE] Apache Sling JCR Contentloader 2.2.2 >>>> >>>>I would like to call a vote on the following release, >>>> >>>>Apache Sling JCR Contentloader 2.2.2 >>>> >>>>We solved 1 issues in this release: >>>>https://issues.apache.org/jira/browse/SLING/fixforversion/12340508 >>>> >>>>Staging repository: >>>>https://repository.apache.org/content/repositories/orgapachesling-1728/ >>>> >>>>You can use this UNIX script to download the release and verify the >>>>signatures: >>>>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh >>>> >>>>Usage: >>>>sh check_staged_release.sh 1728 /tmp/sling-staging >>>> >>>>Please vote to approve this release: >>>> >>>> [ ] +1 Approve the release >>>> [ ] 0 Don't care >>>> [ ] -1 Don't release, because ... >>> >> >> >> >>-- >>Karl Pauls >>[email protected] > -- Karl Pauls [email protected]
