[
https://issues.apache.org/jira/browse/SLING-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057409#comment-16057409
]
Konrad Windszus commented on SLING-6976:
----------------------------------------
At the same time I would rather deprecate the methods {{binaryFile}} and
{{binaryResource}} taking an InputStream and the path only as parameter and
instead recommend to use the overloaded methods taking the mimeType as
additional parameter.
> ContentLoader.binaryFile() should try to derive mimetype from classpath
> resource rather than from target property name
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-6976
> URL: https://issues.apache.org/jira/browse/SLING-6976
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Affects Versions: Testing Sling Mock 2.2.12
> Reporter: Konrad Windszus
>
> Currently the {{ContentLoader.binaryFile}} tries to derive the mime type from
> the target property which should contain the binary
> (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L226).
> This is useless, as the property name almost never contains an extension
> from which a mimetype could be derived. Instead the first argument (namely
> {{classpathResource}} should be taken as basis to derive the mime type from).
> Currently in practically all cases the mime type will be set to the default
> value
> (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L466)
> which is {{application/octet-stream}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
