[
https://issues.apache.org/jira/browse/SLING-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-6976.
-----------------------------------
Resolution: Fixed
Assignee: Stefan Seifert
Fix Version/s: Testing Sling Mock 2.2.14
Testing Sling Mock 1.9.10
thanks - i've applied it to 2.x and 1.x
Completed: At revision: 1799508 (2.x)
Completed: At revision: 1799509 (1.x)
> ContentLoader.binaryFile() and ContentLoader.binaryResource() should try to
> derive mimetype from classpath resource rather than from target resource name
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-6976
> URL: https://issues.apache.org/jira/browse/SLING-6976
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Affects Versions: Testing Sling Mock 2.2.12
> Reporter: Konrad Windszus
> Assignee: Stefan Seifert
> Fix For: Testing Sling Mock 1.9.10, Testing Sling Mock 2.2.14
>
> Attachments: SLING-6976-v01.patch, SLING-6976-v02.patch
>
>
> Currently the {{ContentLoader.binaryFile}} tries to derive the mime type from
> the target resource name which should contain the binary
> (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L226).
> This is often useless, as the resource name almost never contains an
> extension from which a mimetype could be derived (very often a generic name
> like "file" is used). Instead the first argument (namely
> {{classpathResource}} should be taken as basis to derive the mime type from).
> Currently in practically all cases the mime type will be set to the default
> value
> (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L466)
> which is {{application/octet-stream}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
