[ 
https://issues.apache.org/jira/browse/SLING-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073685#comment-16073685
 ] 

Carsten Ziegeler commented on SLING-6996:
-----------------------------------------

Lgtm, but I think we should add unit tests (verifying that it is broken before 
your patch and works after the patch)

> Root Mappings for Resource Resolution don't work correctly when sling:match 
> contains a regex in the host part
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-6996
>                 URL: https://issues.apache.org/jira/browse/SLING-6996
>             Project: Sling
>          Issue Type: Bug
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.5.24
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>             Fix For: Resource Resolver 1.5.26
>
>         Attachments: SLING-6996.patch
>
>
> Looking at 
> http://sling.apache.org/documentation/the-sling-engine/mappings-for-resource-resolution.html#root-level-mappings
>  it should be possible to match ports in the sling:match e.g.:
> sling:match = http/localhost.\d*
> should match regardless of the host port. However, that currently isn't the 
> case as the resource resolver erroneously detects this as a host without port 
> and appends the default port to the pattern.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to