Carsten Ziegeler commented on SLING-7039:

[~kpauls] I think the patch is ok. If I understand it correctly you wait the 
configured time in between clean ups which means that in some cases jobs are 
staying there for nearly double the configured time (e.g. if they are created 
47h 59minutes before the clean up task runs). That should be fine but might 
create confusion (I see a three days old job there although the configuration 
is set to two days)

> Clean up jobs in state dropped and errors
> -----------------------------------------
>                 Key: SLING-7039
>                 URL: https://issues.apache.org/jira/browse/SLING-7039
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Carsten Ziegeler
>            Assignee: Karl Pauls
>             Fix For: Event 4.3.0
>         Attachments: SLING-7039.patch
> Currently, whenever a job is removed by a user (or client code), the job is 
> kept as a dropped job - regardless of whether a history should be kept for 
> these types of jobs. The same happens if the job can't be scheduled (error).
> This information is useful for trouble shooting (to find out if a particular 
> job has been created at all or not).
> Now, as the job impl is keeping track of these things, I think it also should 
> be the job impl which cleans this up. The configuration for this would be a 
> time period during which these jobs are kept (like 48h or something). All 
> older jobs are removed.
> Or in other words: the job impl should periodically run the 
> HistoryCleanUpTask to remove jobs in state DROPPED and ERROR which are older 
> than the configured time.
> I think the time would be a global configuration of the job handling, 
> defaulting to 48h

This message was sent by Atlassian JIRA

Reply via email to