[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130310#comment-16130310
 ] 

Robert Munteanu commented on SLING-7055:
----------------------------------------

Thanks for the patch [~mreutegg] . I would have only two comments:

* Bundles living under commons should have no dependency on Sling, so you could 
either remove the link to the Sling settings service or move the bundle to 
extensions
* The bundle uses guava, but in quite a limited manner. We try to avoid this 
dependency since it's quite heavyweight and problematic in terms of backwards 
compatibility. Could you remove that dependency?

> RRD4J metrics reporter
> ----------------------
>
>                 Key: SLING-7055
>                 URL: https://issues.apache.org/jira/browse/SLING-7055
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Marcel Reutegger
>            Assignee: Robert Munteanu
>            Priority: Minor
>         Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to