[
https://issues.apache.org/jira/browse/SLING-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132193#comment-16132193
]
Bertrand Delacretaz edited comment on SLING-6984 at 8/18/17 1:37 PM:
---------------------------------------------------------------------
[~marett] the below patch breaks the integration tests. probably because the
service used doesn't exist.
I think trying to disable a non-existing service user should just log an INFO
message but not fail, as in many cases I suppose what people mean is "disable
service user if it exists". WDYT?
{code}
Index: bundles/extensions/repoinit/it/src/main/provisioning/repoinit.txt
===================================================================
--- bundles/extensions/repoinit/it/src/main/provisioning/repoinit.txt
(revision 1805421)
+++ bundles/extensions/repoinit/it/src/main/provisioning/repoinit.txt
(working copy)
@@ -48,6 +48,8 @@
create service user thirdUserFromProvisioningModel
disable service user thirdUserFromProvisioningModel : "Disabled for testing
reason"
+disable service user nonExisting3733bbc56b8a8364828d580821d97b88933c071d :
"This should just log a message, we really mean 'disable service user if it
exists'"
+
register namespace (slingtest) http://sling.apache.org/ns/test/repoinit-it/v1.0
register nodetypes
{code}
was (Author: bdelacretaz):
@maret the below patch breaks the integration tests. probably because the
service used doesn't exist.
I think trying to disable a non-existing service user should just log an INFO
message but not fail, as in many cases I suppose what people mean is "disable
service user if it exists". WDYT?
{code}
Index: bundles/extensions/repoinit/it/src/main/provisioning/repoinit.txt
===================================================================
--- bundles/extensions/repoinit/it/src/main/provisioning/repoinit.txt
(revision 1805421)
+++ bundles/extensions/repoinit/it/src/main/provisioning/repoinit.txt
(working copy)
@@ -48,6 +48,8 @@
create service user thirdUserFromProvisioningModel
disable service user thirdUserFromProvisioningModel : "Disabled for testing
reason"
+disable service user nonExisting3733bbc56b8a8364828d580821d97b88933c071d :
"This should just log a message, we really mean 'disable service user if it
exists'"
+
register namespace (slingtest) http://sling.apache.org/ns/test/repoinit-it/v1.0
register nodetypes
{code}
> Allow to disable service user
> -----------------------------
>
> Key: SLING-6984
> URL: https://issues.apache.org/jira/browse/SLING-6984
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
> Affects Versions: Repoinit Parser 1.1.0, Repoinit JCR 1.1.4
> Reporter: Timothee Maret
> Assignee: Timothee Maret
> Fix For: Repoinit Parser 1.1.2, Repoinit JCR 1.1.6
>
>
> Currently the repoinit module does not support -removing- disabling service
> users.
> Disbling -Removing- service user is required when one user is no longer
> needed due to service user sharing among components.
> The syntax could be the one proposed by [~anchela]
> {code}
> disable service user <serviceUserId> <disableMessage>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
