[
https://issues.apache.org/jira/browse/SLING-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139972#comment-16139972
]
Marcel Reutegger edited comment on SLING-7074 at 8/24/17 12:25 PM:
-------------------------------------------------------------------
Looks very good to me.
Regarding the path. IIUC the activate would throw an exception if I remove the
path configuration entry. What do you think about a fallback to the default
path in that case?
Btw, the title for this issue should probably be changed as well. This isn't
just about data sources after all.
was (Author: mreutegg):
Looks very good to me.
Regarding the path. IIUC the activate would throw an exception if I remove the
path configuration entry. What do you think about a fallback to the default
path in that case?
> RRD4J NPE on removing all "Data sources" from config
> ----------------------------------------------------
>
> Key: SLING-7074
> URL: https://issues.apache.org/jira/browse/SLING-7074
> Project: Sling
> Issue Type: Bug
> Components: Commons
> Reporter: Alex Deparvu
> Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7074.patch
>
>
> Opened the config manager and deleted all entries
> {noformat}
> *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent:
> pid=org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter)]
> org.apache.sling.commons.metrics-rrd4j
> [org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3134)]
> The activate method has thrown an exception (java.lang.NullPointerException)
> java.lang.NullPointerException: null
> at
> org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.withDatasources(RRD4JReporter.java:91)
> at
> org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:143)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> fyi [~mreutegg]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
