[
https://issues.apache.org/jira/browse/SLING-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156240#comment-16156240
]
ASF GitHub Bot commented on SLING-7112:
---------------------------------------
GitHub user HaroldPutman opened a pull request:
https://github.com/apache/sling/pull/251
Add support for Private Use Country codes
Resolves SLING-7112 by allowing the private use country codes as defined in
[IANA Language Subtag
Registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
AA, QM-QZ, XA-XZ, ZZ
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HaroldPutman/sling
SLING-7112-allow-private-use-country
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #251
----
commit 9f24596e4efbaeb01fee3b852e338783eaa28255
Author: Harold Putman <[email protected]>
Date: 2017-09-07T00:15:36Z
Add support for Private Use Country codes
Resolves SLING-7112 by allowing the private use country codes as defined in
[IANA Language Subtag
Registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
AA, QM-QZ, XA-XZ, ZZ
----
> @i18n in HTL fails on private-use country codes
> -----------------------------------------------
>
> Key: SLING-7112
> URL: https://issues.apache.org/jira/browse/SLING-7112
> Project: Sling
> Issue Type: Bug
> Components: i18n
> Environment: Mac OS, AEM
> Reporter: Harold Putman
> Priority: Minor
>
> In HTL the @i18n tag fails when jcr:language not in ISO list.
> es_PY falls back to es, but es_XL falls back to default en.
> I think this is related to the check for valid countries in
> JcrResourceBundleProvider::toLocale().
> If you feel you must check for valid country code, please also allow case
> where country code starts with X which is allowed by the [IANA
> spec](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry).
> ```
> %%
> Type: region
> Subtag: XA..XZ
> Description: Private use
> Added: 2005-10-16
> ```
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
