Hi Ian Sounds good. Feel free to apply my refactoring of the HelperData[0] if that makes your patch simpler.
Regards Julian [0] https://github.com/apache/sling/compare/trunk...jsedding:refactor-jcr-helper-data On Tue, Sep 19, 2017 at 12:41 PM, Ian Boston <i...@tfd.co.uk> wrote: > Hi, > > On 19 September 2017 at 11:00, Julian Sedding <jsedd...@gmail.com> wrote: >> >> Hi Ian >> >> On Tue, Sep 19, 2017 at 10:42 AM, Ian Boston <i...@tfd.co.uk> wrote: > > > <snip> > >> >> With the upcoming changes in Jackrabbit we will already have the >> URIProvider service(s), which does JCR Value -> URI conversion. >> Interested parties can use it independent of >> Resource/ResourceResolver. Or am I missing something? >> > > Yes, they can if they bind to the Oak API, which IMHO needs to be > discouraged as it bypasses the Resource API and the JCR API, hence the > suggestion to expose the URIConverter as an API. > > but, Carsten is correct. > > For the issue that triggered OAK-6575 to be fixed in Sling only requires a > Resource->InputStream cast to ExternalizableInputStream pattern. > > In which case path 2 (HelperData is simplest). > > If so, at some later date other services can bind to the URIProvider API > should they be required. No point in trying to solve everything in 1 patch. > > Best Regards > Ian > > >> >> Regards >> Julian >> >> >
