[
https://issues.apache.org/jira/browse/SLING-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela updated SLING-7144:
--------------------------
Attachment: SLING-7144.patch
JcrSystemUserValidatorTest.patch
Proposed patch for {{JcrSystemUserValidator}}.
I wanted to write tests for the change and additionally extend the somewhat
poor test coverage with {{JcrSystemUserValidatorTest}}... unfortunately that
test is based on {{RepositoryTestBase}}, which afaik cannot run against an Oak
repository and thus cannot be used for the tests I wanted to contribute.
{{JcrSystemUserValidatorTest.patch}} illustrates how the tests should look like
IMHO but they currently fail due to the dependency to the Jackrabbit 2.x...
maybe it would be time to adjust {{RepositoryBaseTest}}?
> JcrSystemUserValidator should identify disabled users as invalid
> ----------------------------------------------------------------
>
> Key: SLING-7144
> URL: https://issues.apache.org/jira/browse/SLING-7144
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Reporter: angela
> Attachments: JcrSystemUserValidatorTest.patch, SLING-7144.patch
>
>
> The {{JcrSystemUserValidator}} verifies that a given service mapping points
> to an existing, valid system user. However, it doesn't take
> {{User.isDisabled()}} into account.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
