On Monday 09 October 2017 11:54:17 Robert Munteanu wrote: > Hi, Hi,
> On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote: > > I understand that I can commit to both the Gitbox repo as well as the > > linked Github repo now. The former works without further actions for > > the latter 2fa needs to be enabled on github and the account needs to > > be properly linked. > > I am wondering which of the two URLs should be used within the > > pom.xmls? > > For me it would rather be the native gitbox URL (as documented now in > > https://reference.apache.org/committer/git) instead of the Github > > one. Mostly because gitbox is controlled by the ASF Infra team while > > Github is not. > > Also for documentation purposes we should always point to mainly the > > Apache one and mention the Github repo as an additional option. > > > > With https://github.com/apache/sling-> > > > site/commit/2f5dbedefff3fcaa0639716d59c0806620337fd0 the pubScmUrl > > has been changed from git-wip to Github. IMHO this should rather be > > the gitbox url as this allows every committer to publish, even if > > she/he has not yet set-up the linking of the Github account. This > > makes publishing less error-prone as for the gitbox URL no further > > prerequisites need to be fulfilled and one can just commit with the > > Apache LDAP ID and password. > > Thanks for bringing this up, I don't think we explicitly discussed it. > > I think that github should be the canonical URL, for the following > reasons: > > - account linking and personal access token generation are one-time > actions that take little time to perform > - making github the preferred push repository makes me more confident > that we won't have any conflicts due to merging pull requests > - automation is more readily available with github rather than gitbox > and we may choose to add more automation in the future > > Also, pushing to github is a supported setup, this was why we decided > to go with gitbox in the first place [1]. Pushing to the ASF repos sort > of defeats the purpose of that. why is making GitBox URLs the canonical ones (IMHO those URLs *are* the canonical ones) defeating anything? Regards, O. > Robert > > [1]: https://lists.apache.org/thread.html/5ec516396d30c5c6b722da8095230 > a792f0972ab25dd651a96dd56be@%3Cdev.sling.apache.org%3E
