[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ian Boston reopened SLING-6609:
-------------------------------
mvn clean javadoc:javadoc fails, due to this commit blocking releasing the
bundle.
Could you fix please.
The JavaDoc didn't make sense as there is no get(String) method.
{code}
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13.165 s
[INFO] Finished at: 2017-11-02T14:32:34+00:00
[INFO] Final Memory: 27M/385M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:javadoc (default-cli) on
project org.apache.sling.api: An error has occurred in JavaDocs report
generation:
[ERROR] Exit code: 1 -
/Users/ieb/sling/sling-org-apache-sling-api/src/main/java/org/apache/sling/api/resource/ValueMap.java:77:
error: reference not found
[ERROR] * Therefore all implementations should internally call {@link
#get(String)} when the 2nd parameter
[ERROR] ^
[ERROR]
/Users/ieb/sling/sling-org-apache-sling-api/src/main/java/org/apache/sling/api/resource/ValueMap.java:90:
warning - Tag @link: can't find get(String) in
org.apache.sling.api.resource.ValueMap
[ERROR]
[ERROR] Command line was:
/Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home/jre/../bin/javadoc
@options @packages
[ERROR]
{code}
> Fix JSR305 annotations for ValueMap.get
> ---------------------------------------
>
> Key: SLING-6609
> URL: https://issues.apache.org/jira/browse/SLING-6609
> Project: Sling
> Issue Type: Bug
> Components: API
> Affects Versions: API 2.16.2
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: API 2.16.4
>
>
> Currently {{<T> T get(@Nonnull String name, T defaultValue);}} does neither
> define a JSR 305 annotation for the return value nor for the 2nd parameter.
> It makes sense to define them both as {{@Nonnull}}, because if you intend to
> get {{null}} as return value you are supposed to take the other get method
> ({{@CheckForNull <T> T get(@Nonnull String name, @Nonnull Class<T> type)}})
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
