[ 
https://issues.apache.org/jira/browse/SLING-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246690#comment-16246690
 ] 

Karl Pauls edited comment on SLING-7186 at 11/9/17 10:45 PM:
-------------------------------------------------------------

I updated the pull request and I think we are close. 

The idea for now is that we are limiting the packages exported in java9 to the 
same set we expose on previous java version. The difference is that we will now 
be able to substract missing packages (in case we are not running with 
--add-modules java.se.ee). 

This is not optimal as it would be better to not have to require java.se.ee (or 
--add-modules for that matter) at all but at a minimum, it should be a good 
basis for working towards that goal (as we can just start to remove the 
java.se.ee modules from the module path and substitute the extension bundles 
with real implementations). This however, will require some more investigation 
on how to actually do that in a good way and still be able to run on older java 
versions as well. 

In other words, for the time being we will still require --add-modules 
java.se.ee but we should be in much better shape. What is left is to wait for 
the next felix framework release.


was (Author: karlpauls):
I updated the pull request and I think we are close. 

The idea for now is that we are limiting the packages exported in java9 to the 
same set we expose on previous java version. The difference is that we will now 
be able to substract missing packages (in case we are not running with 
--add-modules java.se.ee). 

This is not optimal as it would be better to not have to require java.se.ee (or 
--add-modules for that matter) at all but at a minimum, it should be a good 
basis for working towards that goal (as we can just start to remove the 
java.se.ee modules from the module path an substitute the extension bundles 
with real implementations). This however, will require some more investigation 
on how to actually do that in a good way and still be able to run on older java 
versions as well. 

In other words, for the time being we will still require --add-modules 
java.se.ee but we should be in much better shape. What is left is to wait for 
the next felix framework release.

> System bundle + extension bundles should only export available packages on 
> java9
> --------------------------------------------------------------------------------
>
>                 Key: SLING-7186
>                 URL: https://issues.apache.org/jira/browse/SLING-7186
>             Project: Sling
>          Issue Type: Improvement
>          Components: Launchpad
>    Affects Versions: Launchpad Base 2.6.24
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>             Fix For: Launchpad Base 2.6.26
>
>
> We need to revisit the packages we export from the system bundle as well as 
> the extension bundles we add when running with java9. The issue is that by 
> default, starting with java9, we only have java.se modules on the module 
> path. Our current packages list + extension bundles assumes java.se.ee to be 
> present (which is not the case unless it is specifically requested via 
> --add-modules). 
> We have to investigate what we want to do to remedy this situation - I'll 
> create subtasks for the actual work (which probably has to include updating 
> to a Felix 5.6.10 when it is released).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to