I'm good with the name change and I've implemented it.

From a web perspective you should never trust the client. If I've implemented a 
form and I require the field to be encrypted internally I should make the 
hidden field required and validate required fields on the server. In the more 
generic Sling sense of sending anything and having it persisted, you'd be 
correct that you'd rely on the person generating the POST. 

-----Original Message-----
From: Bertrand Delacretaz [mailto:[email protected]] 
Sent: Tuesday, November 21, 2017 5:52 AM
To: dev <[email protected]>
Subject: Re: value level encryption - Donating?

EXTERNAL

Hi,

On Mon, Nov 20, 2017 at 2:50 PM, Jason Bailey <[email protected]> wrote:
> https://github.com/JEBailey/sling-encrypt ...

Just a naming nitpick, I think EncryptableValueMap would be a more accurate 
name than EncryptionValueMap.

Also, isn't the use of a client-side form parameter like "personalid@Encrypt" a 
dangerous way to decide what to encrypt? The client can easily "forget" it and 
cause things to be stored in clear.

-Bertrand

Reply via email to