Only one minor nitpick. I would prefer to fill the field "content" either in the constructor or in the init method of the StartupFilter (https://github.com/apache/sling-org-apache-sling-starter-startup/commit/60bc335 <https://github.com/apache/sling-org-apache-sling-starter-startup/commit/60bc335>). Right now it is lazily filled in the doFilter which is called from multiple threads at the same time which could lead to reading the input stream multiple times (due to missing synchronization).
> On 21. Nov 2017, at 17:48, Radu Cotescu <[email protected]> wrote: > > See https://issues.apache.org/jira/browse/SLING-7258. If no one objects > until tomorrow regarding the chosen solution, I'll start a release for the > org.apache.sling.starter.startup module. > > Thanks, > Radu > > On Tue, 21 Nov 2017 at 11:31 Bertrand Delacretaz <[email protected]> > wrote: > >> hi Radu, >> >> On Tue, Nov 21, 2017 at 10:27 AM, Radu Cotescu <[email protected]> wrote: >>> ...2. the Servlet Filter registered by org.apache.sling.starter.startup >> should >>> in fact return a 503 - Service Unavailable, with the current response >> body >>> mentioning that Apache Sling is starting... >> >> +1 for this option. >> >> -Bertrand >>
