[ 
https://issues.apache.org/jira/browse/SLING-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265183#comment-16265183
 ] 

Chetan Mehrotra commented on SLING-7045:
----------------------------------------

[~cziegeler] The 2 services are
* MetricsService - Which is actually a ServiceFactory. Not sure how to do that 
with DS
* MetricRegistry - This is more like a factory creation mode i.e. 
MetricsServiceImpl creates a codehale MetricRegistry instance and registers it 
with service registry

So probably we can keep it way it is currently?

> OSGi services should be managed by DS
> -------------------------------------
>
>                 Key: SLING-7045
>                 URL: https://issues.apache.org/jira/browse/SLING-7045
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>            Reporter: Carsten Ziegeler
>             Fix For: commons metrics 1.2.4
>
>
> MetricsServiceImpl is currently registering two services in its activate 
> method - there seems to be no real reason doing this manually and the 
> services should rather be registered by DS



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to