kwin commented on a change in pull request #1: SLING-5668 - Leverage
ServletRequestListener.requestDestroyed for cal?
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155639654
##########
File path: src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
##########
@@ -1256,4 +1300,16 @@ private Object handleBoundModelResult(Result<?> result)
{
scriptEngineFactory,
bindingsValuesProvidersByContext).adaptTo(targetClass);
}
+ @Override
+ public void requestDestroyed(ServletRequestEvent sre) {
+ ServletRequest request = unwrapRequest(sre.getServletRequest());
Review comment:
I also find it weird, that this event does still contained a wrapped servlet
request. But unwrapping does not do any harm (in no case).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
