[
https://issues.apache.org/jira/browse/SLING-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300280#comment-16300280
]
ASF GitHub Bot commented on SLING-7321:
---------------------------------------
justinedelson commented on a change in pull request #3: SLING-7321
ChildResourceViaProvider support wrapping request
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/3#discussion_r158327783
##########
File path:
src/main/java/org/apache/sling/models/impl/via/ChildResourceViaProvider.java
##########
@@ -40,8 +46,36 @@ public Object getAdaptable(Object original, String value) {
}
if (original instanceof Resource) {
return ((Resource) original).getChild(value);
+ } else if (original instanceof SlingHttpServletRequest) {
+ final SlingHttpServletRequest request = (SlingHttpServletRequest)
original;
+ final Resource resource = request.getResource();
+ if (resource == null) {
+ return null;
+ }
+ Resource child = resource.getChild(value);
+ if (child == null) {
+ log.debug("could not obtain child {} of resource {}", value,
resource.getPath());
Review comment:
Please upper case "could" as "Could"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ChildResourceViaProvider should be able to deal with SlingHttpServletRequest
> ----------------------------------------------------------------------------
>
> Key: SLING-7321
> URL: https://issues.apache.org/jira/browse/SLING-7321
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: Sling Models Impl 1.4.6
> Reporter: Santiago García Pimentel
> Priority: Minor
> Fix For: Sling Models Impl 1.4.8
>
>
> The ForcedResourceType and ResourceSuperType are able to deal with Sling
> requests by creating a wrapper request that returns a wrapped Request.
> Still, the ChildResourceViaProvider does not offer such possibility. I think
> that for sake of consistency it should.
> I propose that if the adaptable is a SlingHttpServletRequest the
> ChildResourceViaProvider should create a request wrapper that returns the
> child as given in 'value'
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
