justinedelson commented on a change in pull request #3: SLING-7321
ChildResourceViaProvider support wrapping request
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/3#discussion_r158327488
##########
File path:
src/main/java/org/apache/sling/models/impl/via/ChildResourceViaProvider.java
##########
@@ -19,15 +19,21 @@
import org.apache.commons.lang3.StringUtils;
import org.apache.felix.scr.annotations.Component;
import org.apache.felix.scr.annotations.Service;
+import org.apache.sling.api.SlingHttpServletRequest;
import org.apache.sling.api.resource.Resource;
+import org.apache.sling.api.wrappers.SlingHttpServletRequestWrapper;
import org.apache.sling.models.annotations.ViaProviderType;
import org.apache.sling.models.annotations.via.ChildResource;
import org.apache.sling.models.spi.ViaProvider;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@Component
@Service
public class ChildResourceViaProvider implements ViaProvider {
+ protected final Logger log = LoggerFactory.getLogger(getClass());
Review comment:
Please make `private static final` to match other classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
