[ 
https://issues.apache.org/jira/browse/SLING-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316686#comment-16316686
 ] 

ASF GitHub Bot commented on SLING-7357:
---------------------------------------

tteofili commented on issue #2: SLING-7357: set content type to forward distrib 
http headers
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/2#issuecomment-356045092
 
 
   the patch looks good to me.
   @Buuhuu while I agree it is better for HTTP request to state the content 
type, does this PR relate to an issue or functional requirement ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Send Content-Type header along with the DistributionPackage's content in 
> forward distribution
> ---------------------------------------------------------------------------------------------
>
>                 Key: SLING-7357
>                 URL: https://issues.apache.org/jira/browse/SLING-7357
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content Distribution
>            Reporter: Dirk Rudolph
>            Priority: Minor
>
> Currently SimpleHttpDistributionTransport only adds Connection and Digest 
> http header (if configured to do so) to the http request. When integrating 
> into other systems then sling the API might require the content type of the 
> package transmitted to be present. 
> I see to options to support that:
> a) implement configureable headers for the http transport similar to the 
> timeouts. This might clash with headers set by the implementation
> b) let the serializer specify the type of the content it generates. This will 
> be an API change in the core bundle.
> From my perspective b) will be simpler to implement.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to