[
https://issues.apache.org/jira/browse/SLING-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318219#comment-16318219
]
ASF GitHub Bot commented on SLING-7360:
---------------------------------------
tteofili commented on issue #4: SLING-7360: support creating delete
distribution packages by serializer
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/4#issuecomment-356243757
@Buuhuu could you help resolving the above conflicts ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support creation of DistributionPackages for delete by
> DistributionContentSerializer
> ------------------------------------------------------------------------------------
>
> Key: SLING-7360
> URL: https://issues.apache.org/jira/browse/SLING-7360
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
> Reporter: Dirk Rudolph
> Priority: Minor
>
> For the integration into systems or then sling, that support
> creation/deletion as part of their API [1], we can implement a
> {{DistributionContentSerializer}} writing the format the API expects. That
> currently works well for creation but not for deletion because both
> {{FileDistributionPackageBuilder}} and {{ResourceDistributionPackageBuilder}}
> inherit from {{AbstractDistributionPackageBuilder}} which [returns a
> SimpleDistributionPackage|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/packaging/impl/AbstractDistributionPackageBuilder.java#L72]
> for {{DistributionRequestType.DELETE}}.
> The other system's API might expect a different format then the one written
> by {{SimpleDistributionPackage}} so it would be create if it would be
> possible to delegate the creation of a deletion package to the serializer as
> well, in case the serializer supports that.
> [1]
> https://lucene.apache.org/solr/guide/7_2/uploading-data-with-index-handlers.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)