Hi Robert. Agree on all points above :)
I'll create an issue and link it. - Andrei On Thu, Jan 18, 2018 at 5:17 PM Robert Munteanu <romb...@apache.org> wrote: > Hi Andrei, > > Even though '@trivial', these kind of changes deserve their own Jira > issue. Please create one after the fact and link to commit to it ( via > a Jira comment). > > I agree not all changes need a Jira issue, but 'trivial' issues IMO are > mostly formatting and Javadoc fixes, not ones that change behaviour. > > Thanks, > > Robert > > P.S. We should stop mentioning https://github.com/trivial on our > commits, I guess it's kind of annoying :-) > > > ---------- Forwarded message ---------- > From: Andrei Tuicu <notificati...@github.com> > To: "apache/sling-org-apache-sling-testing-clients" < > sling-org-apache-sling-testing-clie...@noreply.github.com> > Cc: Subscribed <subscri...@noreply.github.com> > Bcc: > Date: Thu, 18 Jan 2018 14:47:03 +0000 (UTC) > Subject: [apache/sling-org-apache-sling-testing-clients] @trivial - The > poller should wait for the delay even in case of exceptions (#4) > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/sling-org-apache-sling-testing-clients/pull/4 > Commit Summary > > - @trivial - The poller should wait for the delay even in case of > exceptions > > File Changes > > - *M* > src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java > > <https://github.com/apache/sling-org-apache-sling-testing-clients/pull/4/files#diff-0> > (4) > > Patch Links: > > - > > https://github.com/apache/sling-org-apache-sling-testing-clients/pull/4.patch > - > > https://github.com/apache/sling-org-apache-sling-testing-clients/pull/4.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/sling-org-apache-sling-testing-clients/pull/4>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABS9T8jT2BDRErjVz-jZ7p8X9-VmgBtks5tL1lngaJpZM4RjCEV> > . >
