[ 
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332219#comment-16332219
 ] 

Oliver Lietz commented on SLING-7251:
-------------------------------------

[~npeltier], didn't notice I had to activate ITs with profile... after that no 
succesful build at all.
The IT has several issues (don't forget: you're testing against real Sling):
* request is not authenticated
* IT uses private Pipes package ({{org.apache.sling.pipes.internal.JsonWriter}} 
and {{org.apache.sling.pipes.internal.JsonUtil}})
* there is no service user and ACL for Pipes

I've done some more optimization:
* updated to Parent 33-SNAPSHOT and Testing PaxExam 1.0.0-SNAPSHOT (not 
required, for convenience only) 
* added [Resource 
Presence|https://github.com/apache/sling-org-apache-sling-resource-presence] to 
ensure presence of {{/etc/pipes-it}}
* removed {{logging()}} as {{exam.properties}} is missing and log in 
{{target/failsafe-reports}} is sufficient

Please have a look at branch 
[issue/SLING-7251|https://github.com/apache/sling-org-apache-sling-pipes/tree/issue/SLING-7251].
* ACL should be improved
* {{assertEquals("there should be 2 elements", 2, ((Double) 
main.get("size")).intValue());}} is ugly
* use {{bnd-maven-plugin}} instead of {{maven-bundle-plugin}}


> Fix pipes plumber servlet IT 
> -----------------------------
>
>                 Key: SLING-7251
>                 URL: https://issues.apache.org/jira/browse/SLING-7251
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: pipes 2.0.0
>            Reporter: Nicolas Peltier
>            Assignee: Oliver Lietz
>            Priority: Major
>
> new Plumber servlet IT fail. This should be fixed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to