[
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360421#comment-16360421
]
ASF GitHub Bot commented on SLING-7423:
---------------------------------------
rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#discussion_r167486967
##########
File path: pom.xml
##########
@@ -208,6 +208,13 @@
<artifactId>slf4j-api</artifactId>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-jdk14</artifactId>
Review comment:
Does `slf4j-simple` work here as well? I don't strongly prefer either
dependency, but since we use `slf4j-simple` in most other places it would be
more consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade Oak to 1.8
> ------------------
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
> Issue Type: Sub-task
> Affects Versions: JCR Oak Server 1.1.4
> Reporter: Christian Schneider
> Assignee: Oliver Lietz
> Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API
> was changed in an incompatible way. We should adapt to these changes. See
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator;
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; ->
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; ->
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider;
> -> oak-core
> ----
> Preparing for Oak 1.8 in branch
> [feature/oak-1.8|https://github.com/apache/sling-org-apache-sling-jcr-oak-server/tree/feature/oak-1.8].
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
