Carsten Ziegeler commented on SLING-7499:

Looks basically good to me, two comments:

- the initial trim() is not really needed (just to detect the delimiters) and 
in most cases wasted work (I don't think it matters that much though)
- the new trim code only trims spaces but not whitespaces

> ResourceResolver trims whitespace at the end of path.
> -----------------------------------------------------
>                 Key: SLING-7499
>                 URL: https://issues.apache.org/jira/browse/SLING-7499
>             Project: Sling
>          Issue Type: Bug
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.5.34
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>            Priority: Major
>             Fix For: Resource Resolver 1.5.36
> When a sling:alias is set for a page and contains a whitespace at the end of 
> its name, then this is cut off by resourceResolver.map().
> The trimming is only performed for the trailing white-space.

This message was sent by Atlassian JIRA

Reply via email to