[
https://issues.apache.org/jira/browse/SLING-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371382#comment-16371382
]
ASF GitHub Bot commented on SLING-7507:
---------------------------------------
karlpauls opened a new pull request #2: SLING-7507: open the service tracker
when the LogbackManager is inita…
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/2
…lized to prevent an NPE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Tracker open to early which can cause a NPE.
> --------------------------------------------
>
> Key: SLING-7507
> URL: https://issues.apache.org/jira/browse/SLING-7507
> Project: Sling
> Issue Type: Bug
> Components: Commons
> Affects Versions: Commons Log 5.1.0
> Reporter: Karl Pauls
> Priority: Major
> Fix For: Commons Log 5.1.2
>
>
> The FilterTracker and TurboFilterTracker service tracker are opened in the
> constructor of the LogbackManager at a time when it isn't fully configured
> yet. That can lead to an NPE if there is a service found right away.
> {code:java}
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.sling.commons.log.logback.internal.LogbackManager$LoggerStateContext.<init>(LogbackManager.java:733)
> at
> org.apache.sling.commons.log.logback.internal.LogbackManager.determineLoggerState(LogbackManager.java:663)
> at
> org.apache.sling.commons.log.logback.internal.FilterTracker.getAppenderMap(FilterTracker.java:173)
> at
> org.apache.sling.commons.log.logback.internal.FilterTracker.addingService(FilterTracker.java:67)
> at
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941)
> at
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:870)
> at
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
> at
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
> at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:318)
> at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:261)
> at
> org.apache.sling.commons.log.logback.internal.FilterTracker.<init>(FilterTracker.java:55)
> at
> org.apache.sling.commons.log.logback.internal.LogbackManager.<init>(LogbackManager.java:153)
> at
> org.apache.sling.commons.log.logback.internal.Activator.initializeLogbackManager(Activator.java:75)
> at
> org.apache.sling.commons.log.logback.internal.Activator.start(Activator.java:55)
> at
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:697)
> at org.apache.felix.framework.Felix.activateBundle(Felix.java:2240)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
