[
https://issues.apache.org/jira/browse/SLING-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377598#comment-16377598
]
Justin Edelson edited comment on SLING-7508 at 2/26/18 9:26 PM:
----------------------------------------------------------------
sorry [~diru] was on vacation. the patch looks good to me. I wanted to make
sure there is a clean IT for this before merging – the IT you have is a bit
complicated. PR has been merged and a new IT has been added.
Thanks!
was (Author: justinedelson):
sorry [~diru] was on vacation. the patch looks good to me. I wanted to make
sure there is a clean IT for this before merging – the IT you have is a bit
complicated.
> StackOverflowError adapting ServletResource to Sling Model with impl picker
> ---------------------------------------------------------------------------
>
> Key: SLING-7508
> URL: https://issues.apache.org/jira/browse/SLING-7508
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Sling Models Impl 1.4.2
> Reporter: Dirk Rudolph
> Assignee: Justin Edelson
> Priority: Major
> Fix For: Sling Models Impl 1.4.8
>
>
> Adapting a {{SlingHttpServletRequest}} to a servlet that is registered using
> sling.servlet.paths to a {{@Model}} fails in the following StackOverflowError:
> {code}
> java.lang.StackOverflowError: null
> ...
> at
> org.apache.sling.models.impl.AdapterImplementations.getModelClassForResource(AdapterImplementations.java:318)
> at
> org.apache.sling.models.impl.AdapterImplementations.getModelClassForResource(AdapterImplementations.java:322)
> at
> org.apache.sling.models.impl.AdapterImplementations.getModelClassForResource(AdapterImplementations.java:322)
> {code}
> See for example the following pseudo code:
> {code}
> @SlingServlet(paths = "/apps/mypath")
> class MyServlet extends SlingSafeMethodsServlet {
> doGet(request) { request.adaptTo(Model.class); }
> }
> interface Model {
> ...
> }
> @Model(adaptables = SlingHttpServletRequest.class, adapters =
> {ModelImpl.class, Model.class})
> class ModelImpl implements Model {
> ...
> }
> {code}
> See the example here:
> https://github.com/Buuhuu/sling-org-apache-sling-models-integration-tests/commit/db174f7a8d43432e4445f4e0aa90487827f66f72
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
