[
https://issues.apache.org/jira/browse/SLING-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391427#comment-16391427
]
Konrad Windszus commented on SLING-7538:
----------------------------------------
[~radu.cotescu] Can you have a look?
> Request attribute not correctly reset after using data-sly-resource or
> data-sly-include with requestAttributes
> --------------------------------------------------------------------------------------------------------------
>
> Key: SLING-7538
> URL: https://issues.apache.org/jira/browse/SLING-7538
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Affects Versions: Scripting HTL Engine 1.0.48-1.3.1
> Reporter: Konrad Windszus
> Priority: Major
>
> The option {{requestAttributes}} introduced with SLING-5812 does not
> correctly reset the request attributes after the request dispatcher returned.
> The reason for that is that
> https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/3b50f91c4f600081f0585e50dfb775c4b2856b89/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/ResourceRuntimeExtension.java#L115
> does only reset those reset attributes which have been previously attached
> to the request. In fact also all attributes which have been added initially
> through the {{requestAttributes}} option need to be removed as well. If you
> add a new request attribute to the request this new request attribute will
> not be removed and would still be leveraged in a subsequent call to
> `data-sly-resource` based on the same request (even if that one doesn't even
> set an option {{requestAttributes}}).
> The same applies to
> https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/3b50f91c4f600081f0585e50dfb775c4b2856b89/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/IncludeRuntimeExtension.java#L73.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
