chetanmeh commented on a change in pull request #3: SLING-7669 StartupManager 
overwrites the frameworkstartlevel property…
URL: 
https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/3#discussion_r189160190
 
 

 ##########
 File path: 
src/main/java/org/apache/sling/launchpad/base/impl/StartupManager.java
 ##########
 @@ -80,6 +80,14 @@
             this.logger.log(Logger.LOG_INFO, "Detected startup mode. Starting 
in mode " + this.mode);
         }
 
+        // populate the sling target start level from the framework one, if 
not set,
+        // otherwise overwrite the framework one
+        if (null == 
properties.get(SharedConstants.SLING_INSTALL_TARGETSTARTLEVEL)) {
 
 Review comment:
   Use `properties.containsKey`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to