rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522141
########## File path: oidc-handler/pom.xml ########## @@ -1,11 +1,35 @@ <?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <groupId>org.apache.sling</groupId> + <artifactId>org.apache.sling.oidchandler</artifactId> Review comment: I think the artifactId should include 'auth' somewhere, to fall in line with our other modules: auth-core, auth-form, auth-xing-oauth. Same goes for the name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
