[
https://issues.apache.org/jira/browse/SLING-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-7679:
-----------------------------------
Description:
Currently there are three different ways on how a model can be given to the
{{slingstart-maven-plugin}}
# external in {{src/main/provisioning}}
# external in {{src/test/provisioning}}
# inline plugin configuration via parameter {{model}}
With SLING-7662 a check though was implemented that either the directory
{{src/main/provisioning}} or {{src/test/provisioning}} must exist for the model
to be detected (even if given inline). This is unexpected, not documented and
should be fixed.
Also there should be a dedicated inline parameter for giving a test model, as
the scope of those dependencies should be different.
So IMHO there should be 4 ways of giving a model:
# external in {{src/main/provisioning}}, only when the directory exists
# external in {{src/test/provisioning}}, only when the directory exists
# inline plugin configuration via parameter {{model}}, only in case element is
not empty
# inline plugin configuration via parameter {{testModel}}, *_new_*, only in
case element is not empty
was:
Currently there are three different ways on how a model can be given to the
{{slingstart-maven-plugin}}
# external in {{src/main/provisioning}}
# external in {{src/test/provisioning}}
# inline plugin configuration via parameter {{model}}
With SLING-7662 a check though was implemented that either the directory
{{src/main/provisioning}} or {{src/test/provisioning}} must exist for the model
to be detected (even if given inline). This is weird and should be cleaned up.
Also there should be a dedicated inline parameter for giving a test model, as
the scope of those dependencies should be different.
> slingstart-maven-plugin: Clarify in-pom vs. external model declaration
> ----------------------------------------------------------------------
>
> Key: SLING-7679
> URL: https://issues.apache.org/jira/browse/SLING-7679
> Project: Sling
> Issue Type: Improvement
> Components: Maven Plugins and Archetypes
> Affects Versions: Slingstart Maven Plugin 1.8.2
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently there are three different ways on how a model can be given to the
> {{slingstart-maven-plugin}}
> # external in {{src/main/provisioning}}
> # external in {{src/test/provisioning}}
> # inline plugin configuration via parameter {{model}}
> With SLING-7662 a check though was implemented that either the directory
> {{src/main/provisioning}} or {{src/test/provisioning}} must exist for the
> model to be detected (even if given inline). This is unexpected, not
> documented and should be fixed.
> Also there should be a dedicated inline parameter for giving a test model, as
> the scope of those dependencies should be different.
> So IMHO there should be 4 ways of giving a model:
> # external in {{src/main/provisioning}}, only when the directory exists
> # external in {{src/test/provisioning}}, only when the directory exists
> # inline plugin configuration via parameter {{model}}, only in case element
> is not empty
> # inline plugin configuration via parameter {{testModel}}, *_new_*, only in
> case element is not empty
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
